diff options
| author | Hsieh Chin Fan <pham@topo.tw> | 2024-09-09 12:23:29 +0800 |
|---|---|---|
| committer | Hsieh Chin Fan <pham@topo.tw> | 2024-09-09 12:27:50 +0800 |
| commit | 00b4e37429c650abc92e53c4ddb1e00de04f3189 (patch) | |
| tree | ad3c55478f4791feda97c08abed566d97df06e1e | |
| parent | 21711f4c942b488b3f2d7eca8861fcc69002f765 (diff) | |
style: Improve code readability
| -rw-r--r-- | rollup.config.js | 6 | ||||
| -rw-r--r-- | src/dumbymap.mjs | 4 | ||||
| -rw-r--r-- | src/editor.mjs | 12 |
3 files changed, 10 insertions, 12 deletions
diff --git a/rollup.config.js b/rollup.config.js index 1dc3a02..d04eb4e 100644 --- a/rollup.config.js +++ b/rollup.config.js | |||
| @@ -50,6 +50,6 @@ export default [ | |||
| 50 | { | 50 | { |
| 51 | input: "src/dumbymap.mjs", | 51 | input: "src/dumbymap.mjs", |
| 52 | }, | 52 | }, |
| 53 | ].map(config => { | 53 | ] |
| 54 | return { ...general, ...config } | 54 | .map(config => ({ ...general, ...config })) |
| 55 | }) | 55 | .filter((config) => production || config.input.match(/editor/)) |
diff --git a/src/dumbymap.mjs b/src/dumbymap.mjs index 6fa05b7..82dcc9a 100644 --- a/src/dumbymap.mjs +++ b/src/dumbymap.mjs | |||
| @@ -240,8 +240,8 @@ export const generateMaps = async (container) => { | |||
| 240 | Object.assign(result, { markers: markersFromLinks }) | 240 | Object.assign(result, { markers: markersFromLinks }) |
| 241 | return result | 241 | return result |
| 242 | }) | 242 | }) |
| 243 | } catch (err) { | 243 | } catch (_) { |
| 244 | console.error('Fail to parse yaml config for element', target, err) | 244 | console.warn('Fail to parse yaml config for element', target) |
| 245 | } | 245 | } |
| 246 | 246 | ||
| 247 | // Render maps | 247 | // Render maps |
diff --git a/src/editor.mjs b/src/editor.mjs index 9c0f59b..ed2ab25 100644 --- a/src/editor.mjs +++ b/src/editor.mjs | |||
| @@ -62,18 +62,18 @@ markdown2HTML(HtmlContainer, tinyEditor.getContent()) | |||
| 62 | // Event Listener: change {{{ | 62 | // Event Listener: change {{{ |
| 63 | 63 | ||
| 64 | // Save editor content to local storage, set timeout for 3 seconds | 64 | // Save editor content to local storage, set timeout for 3 seconds |
| 65 | let rejectLastSaving | 65 | let cancelLastSave |
| 66 | const saveContent = (content) => { | 66 | const saveContent = (content) => { |
| 67 | new Promise((resolve, reject) => { | 67 | new Promise((resolve, reject) => { |
| 68 | // If user is typing, the last change cancel previous ones | 68 | // If user is typing, the last change cancel previous ones |
| 69 | if (rejectLastSaving) rejectLastSaving(content.length) | 69 | if (cancelLastSave) cancelLastSave(content.length) |
| 70 | rejectLastSaving = reject | 70 | cancelLastSave = reject |
| 71 | 71 | ||
| 72 | setTimeout(() => { | 72 | setTimeout(() => { |
| 73 | localStorage.setItem('editorContent', content) | 73 | localStorage.setItem('editorContent', content) |
| 74 | resolve('Content Saved') | 74 | resolve('Content Saved') |
| 75 | }, 3000) | 75 | }, 3000) |
| 76 | }).catch(() => null) | 76 | }).catch((err) => console.warn('Fail to save content', err)) |
| 77 | } | 77 | } |
| 78 | 78 | ||
| 79 | // Render HTML to result container and save current content | 79 | // Render HTML to result container and save current content |
| @@ -216,9 +216,7 @@ const addSuggestions = (currentLine, selection) => { | |||
| 216 | if (renderer) { | 216 | if (renderer) { |
| 217 | 217 | ||
| 218 | // Do not check properties | 218 | // Do not check properties |
| 219 | if (text.startsWith(' ')) { | 219 | if (text.startsWith(' ')) return |
| 220 | return | ||
| 221 | } | ||
| 222 | 220 | ||
| 223 | // If no valid options for current used renderer, go get it! | 221 | // If no valid options for current used renderer, go get it! |
| 224 | const validOptions = rendererOptions[renderer] | 222 | const validOptions = rendererOptions[renderer] |