From 00b4e37429c650abc92e53c4ddb1e00de04f3189 Mon Sep 17 00:00:00 2001 From: Hsieh Chin Fan Date: Mon, 9 Sep 2024 12:23:29 +0800 Subject: style: Improve code readability --- rollup.config.js | 6 +++--- src/dumbymap.mjs | 4 ++-- src/editor.mjs | 12 +++++------- 3 files changed, 10 insertions(+), 12 deletions(-) diff --git a/rollup.config.js b/rollup.config.js index 1dc3a02..d04eb4e 100644 --- a/rollup.config.js +++ b/rollup.config.js @@ -50,6 +50,6 @@ export default [ { input: "src/dumbymap.mjs", }, -].map(config => { - return { ...general, ...config } -}) +] + .map(config => ({ ...general, ...config })) + .filter((config) => production || config.input.match(/editor/)) diff --git a/src/dumbymap.mjs b/src/dumbymap.mjs index 6fa05b7..82dcc9a 100644 --- a/src/dumbymap.mjs +++ b/src/dumbymap.mjs @@ -240,8 +240,8 @@ export const generateMaps = async (container) => { Object.assign(result, { markers: markersFromLinks }) return result }) - } catch (err) { - console.error('Fail to parse yaml config for element', target, err) + } catch (_) { + console.warn('Fail to parse yaml config for element', target) } // Render maps diff --git a/src/editor.mjs b/src/editor.mjs index 9c0f59b..ed2ab25 100644 --- a/src/editor.mjs +++ b/src/editor.mjs @@ -62,18 +62,18 @@ markdown2HTML(HtmlContainer, tinyEditor.getContent()) // Event Listener: change {{{ // Save editor content to local storage, set timeout for 3 seconds -let rejectLastSaving +let cancelLastSave const saveContent = (content) => { new Promise((resolve, reject) => { // If user is typing, the last change cancel previous ones - if (rejectLastSaving) rejectLastSaving(content.length) - rejectLastSaving = reject + if (cancelLastSave) cancelLastSave(content.length) + cancelLastSave = reject setTimeout(() => { localStorage.setItem('editorContent', content) resolve('Content Saved') }, 3000) - }).catch(() => null) + }).catch((err) => console.warn('Fail to save content', err)) } // Render HTML to result container and save current content @@ -216,9 +216,7 @@ const addSuggestions = (currentLine, selection) => { if (renderer) { // Do not check properties - if (text.startsWith(' ')) { - return - } + if (text.startsWith(' ')) return // If no valid options for current used renderer, go get it! const validOptions = rendererOptions[renderer] -- cgit v1.2.3-70-g09d2