From 13b796b5b3207c0d0c9a00e7be9f916d897cda28 Mon Sep 17 00:00:00 2001 From: Hsieh Chin Fan Date: Sat, 19 Oct 2024 19:28:06 +0800 Subject: refactor: use replaceWith() to swap elements --- src/Layout.mjs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Layout.mjs b/src/Layout.mjs index 88faf2d..04acc3d 100644 --- a/src/Layout.mjs +++ b/src/Layout.mjs @@ -219,10 +219,10 @@ export class Overlay extends Layout { } // Set DOMRect for wrapper + block.replaceWith(wrapper) wrapper.appendChild(block) wrapper.style.left = left + 'px' wrapper.style.top = top + 'px' - htmlHolder.appendChild(wrapper) const rect = wrapper.getBoundingClientRect() left += rect.width + 30 if (left > window.innerWidth) { @@ -285,7 +285,7 @@ export class Overlay extends Layout { const resumeFromDraggable = block => { const draggableContainer = block.closest('.draggable-block') if (!draggableContainer) return - htmlHolder.appendChild(block) + draggableContainer.replaceWith(block) draggableContainer.remove() } blocks.forEach(resumeFromDraggable) -- cgit v1.2.3-70-g09d2