From c39dcc9b5a9055fec9a58ce833bd9535ba19b086 Mon Sep 17 00:00:00 2001
From: Hsieh Chin Fan <pham@topo.tw>
Date: Tue, 15 Oct 2024 00:10:39 +0800
Subject: feat: patch 2c9ffa2

* addAnchorByPoint -> addMarkerByPoint
  just return newly created marker
* Add pointByArrow as general element in container
---
 src/dumbyUtils.mjs | 46 +++++++++++++++-------------------------------
 1 file changed, 15 insertions(+), 31 deletions(-)

(limited to 'src/dumbyUtils.mjs')

diff --git a/src/dumbyUtils.mjs b/src/dumbyUtils.mjs
index 7b06840..be0da43 100644
--- a/src/dumbyUtils.mjs
+++ b/src/dumbyUtils.mjs
@@ -190,11 +190,14 @@ export const createGeoLink = (link) => {
     if (link.dataset.valid === 'false') return
 
     removeLeaderLines(link)
-    getMarkersFromMaps(link)
-      .forEach(updateMapCameraByMarker([
+    getMarkersFromMaps(link).forEach(marker => {
+      const map = marker.closest('.mapclay')
+      map.scrollIntoView({ behavior: 'smooth' })
+      updateMapCameraByMarker([
         Number(link.dataset.lon),
         Number(link.dataset.lat),
-      ]))
+      ])(marker)
+    })
   }
 
   // Use middle click to remove markers
@@ -296,43 +299,24 @@ const isAnchorVisible = anchor => {
 }
 
 /**
- * addAnchorByPoint.
+ * addMarkerByPoint.
  *
- * @param {point} options.point - object has {x, y} for window coordinates
+ * @param {Number[]} options.point - page XY
  * @param {HTMLElement} options.map
- * @param {Function} options.validateAnchorName - validate anchor name is OK to use
  */
-export const addAnchorByPoint = ({
-  defaultName,
-  point,
-  map,
-  validateAnchorName = () => true,
-}) => {
+export const addMarkerByPoint = ({ point, map }) => {
   const rect = map.getBoundingClientRect()
-  const [x, y] = map.renderer
-    .unproject([point.x - rect.left, point.y - rect.top])
-    .map(coord => parseFloat(coord.toFixed(6)))
-
-  let prompt
-  let anchorName
-
-  do {
-    prompt = prompt ? 'Anchor name exists' : 'Name this anchor'
-    anchorName = window.prompt(prompt, defaultName ?? '')
-  }
-  while (anchorName !== null && !validateAnchorName(anchorName))
-  if (anchorName === null) return
-
-  const desc = window.prompt('Description', anchorName) ?? anchorName
+  const [lon, lat] = map.renderer
+    .unproject([point[0] - rect.left, point[1] - rect.top])
+    .map(value => parseFloat(value.toFixed(6)))
 
-  const link = `geo:${y},${x}?xy=${x},${y}&id=${map.id}&type=circle`
   const marker = map.renderer.addMarker({
-    xy: [x, y],
+    xy: [lon, lat],
     type: 'circle',
   })
-  marker.dataset.xy = `${x},${y}`
+  marker.dataset.xy = `${lon},${lat}`
 
-  return { ref: anchorName, link, title: desc }
+  return marker
 }
 
 /**
-- 
cgit v1.2.3-70-g09d2