From 1fc35b33eacf0f06370fc14798f65f5ec0972195 Mon Sep 17 00:00:00 2001 From: Hsieh Chin Fan Date: Thu, 31 Oct 2024 17:11:55 +0800 Subject: feat: patch 7ee1ad6 * add spinning circle for Networking UX * display marker for each results --- src/dumbymap.mjs | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) (limited to 'src/dumbymap.mjs') diff --git a/src/dumbymap.mjs b/src/dumbymap.mjs index 77f3515..217c1b6 100644 --- a/src/dumbymap.mjs +++ b/src/dumbymap.mjs @@ -534,6 +534,7 @@ export const generateMaps = (container, { /** MENU: Menu Items for Context Menu */ container.oncontextmenu = e => { + /** Check if OK to show custom menu over context menu */ if (container.dataset.menu === 'disabled') return container.querySelectorAll('.dumby-menu').forEach(m => m.remove()) @@ -554,6 +555,10 @@ export const generateMaps = (container, { container.appendChild(menu) const containerRect = container.getBoundingClientRect() new window.MutationObserver(() => { + if (menu.childElementCount === 0) { + menu.style.display = 'none' + return + } menu.style.display = 'block' menu.style.left = (e.pageX - containerRect.left + 10) + 'px' menu.style.top = (e.pageY - containerRect.top + 5) + 'px' @@ -565,8 +570,10 @@ export const generateMaps = (container, { if (rangeSelected) { // TODO check click is inside selection const range = document.getSelection().getRangeAt(0) - menu.appendChild(menuItem.addLinkbyNominatim(range)) + menu.appendChild(menuItem.addLinkbyGeocoding(range)) + return menu } + /** Menu Item for editing map */ const mapEditor = e.target.closest('.edit-map') if (mapEditor) { @@ -574,7 +581,7 @@ export const generateMaps = (container, { text: 'Finish Editig', onclick: () => mapEditor.blur(), })) - return + return menu } /** Menu Items for Links */ @@ -621,7 +628,7 @@ export const generateMaps = (container, { if (linkWithLine) { menu.appendChild(menuItem.setLeaderLineType(linkWithLine)) - return + return menu } /** Menu Items for map */ -- cgit v1.2.3-70-g09d2