From 6a468847939c8983b7e2ad2a0604d66beebdb94f Mon Sep 17 00:00:00 2001 From: Hsieh Chin Fan Date: Wed, 30 Oct 2024 17:00:45 +0800 Subject: refactor: remove custom elements REASON: apply custom elements in content script may change globalThis which is not equal to window. This makes type check in maplibregl always fails! --- src/dumbymap.mjs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'src/dumbymap.mjs') diff --git a/src/dumbymap.mjs b/src/dumbymap.mjs index 1509c04..7fbf372 100644 --- a/src/dumbymap.mjs +++ b/src/dumbymap.mjs @@ -561,7 +561,7 @@ export const generateMaps = (container, { /** Menu Item for editing map */ const mapEditor = e.target.closest('.edit-map') if (mapEditor) { - menu.appendChild(new menuItem.Item({ + menu.appendChild(menuItem.Item({ text: 'Finish Editig', onclick: () => mapEditor.blur(), })) @@ -572,7 +572,7 @@ export const generateMaps = (container, { const geoLink = e.target.closest('.geolink') if (geoLink) { if (geoLink.classList.contains('from-text')) { - menu.appendChild(new menuItem.Item({ + menu.appendChild(menuItem.Item({ innerHTML: 'DELETE', onclick: () => { getMarkersFromMaps(geoLink) @@ -601,7 +601,7 @@ export const generateMaps = (container, { if (map.dataset.render === 'fulfilled') { menu.appendChild(menuItem.toggleMapFocus(map)) - menu.appendChild(new menuItem.Folder({ + menu.appendChild(menuItem.Folder({ text: 'Actions', items: [ menuItem.getCoordinatesByPixels(map, [x, y]), -- cgit v1.2.3-70-g09d2