From abcc11a69ff25b56e8b4627a5027601fe41882b4 Mon Sep 17 00:00:00 2001
From: Hsieh Chin Fan <pham@topo.tw>
Date: Mon, 16 Sep 2024 22:28:38 +0800
Subject: fix: update text decoration properly

---
 src/editor.mjs | 20 ++++++++++++++------
 1 file changed, 14 insertions(+), 6 deletions(-)

(limited to 'src')

diff --git a/src/editor.mjs b/src/editor.mjs
index d7c26cf..b2c4d54 100644
--- a/src/editor.mjs
+++ b/src/editor.mjs
@@ -347,13 +347,20 @@ const handleTypingInCodeBlock = (anchor) => {
 const getSuggestions = (anchor) => {
   let suggestions = []
   const text = cm.getLine(anchor.line)
-  const markInputIsInvalid = () => {
+
+  // Clear marks on text
+  cm.findMarks(
+    { ...anchor, ch: 0 },
+    { ...anchor, ch: text.length }
+  ).forEach(m => m.clear())
+
+  // Mark user input invalid by case
+  const markInputIsInvalid = () =>
     cm.getDoc().markText(
       { ...anchor, ch: 0 },
-      { ...anchor, ch: -1 },
+      { ...anchor, ch: text.length },
       { className: 'invalid-input' },
     )
-  }
 
   // Check if "use: <renderer>" is set
   const lineWithRenderer = getLineWithRenderer(anchor)
@@ -395,8 +402,8 @@ const getSuggestions = (anchor) => {
     // If user is typing option
     const keyTyped = text.split(':')[0].trim()
     if (!isKeyFinished) {
-      suggestions = getSuggestionsForOptions(keyTyped, validOptions)
       markInputIsInvalid()
+      return getSuggestionsForOptions(keyTyped, validOptions)
     }
 
     // If user is typing value
@@ -409,13 +416,14 @@ const getSuggestions = (anchor) => {
       const valueTyped = text.substring(text.indexOf(':') + 1).trim()
       const isValidValue = matchedOption.isValid(valueTyped)
       if (!valueTyped) {
-        suggestions = [
+        return [
           getSuggestionFromMapOption(matchedOption),
           ...getSuggestionsFromAliases(matchedOption)
         ].filter(s => s instanceof Suggestion)
       }
       if (valueTyped && !isValidValue) {
         markInputIsInvalid()
+        return []
       }
     }
 
@@ -435,7 +443,7 @@ const getSuggestions = (anchor) => {
           replace: `use: ${renderer}`,
         })
       )
-    suggestions = rendererSuggestions.length > 0 ? rendererSuggestions : []
+    return rendererSuggestions.length > 0 ? rendererSuggestions : []
   }
   return suggestions
 }
-- 
cgit v1.2.3-70-g09d2